fix: Fix viewport jumping when navigating in session list after marking fo…#197
Open
ariane-emory wants to merge 7 commits intodevfrom
Open
fix: Fix viewport jumping when navigating in session list after marking fo…#197ariane-emory wants to merge 7 commits intodevfrom
ariane-emory wants to merge 7 commits intodevfrom
Conversation
…r deletion The scroll calculation in moveTo() was happening synchronously before the re-render from setToDelete(undefined) completed its layout pass. Wrapping the scroll logic in setTimeout ensures positions are updated.
ariane-emory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix viewport jumping when navigating in session list after marking for deletion
The scroll calculation in moveTo() was happening synchronously before
the re-render from setToDelete(undefined) completed its layout pass.
Wrapping the scroll logic in setTimeout ensures positions are updated.
Fixes #173
How did you verify your code works?
Manual A/B testing,
bun typecheck,bun test.