-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Argo Workflows 3.6 #1293
Open
elliotgunton
wants to merge
10
commits into
main
Choose a base branch
from
upgrade-to-argo-3.6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Manually update scripts/spec.py to remove Container remapping of `enum` field (it is now a string) Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
* NOTE THIS IS BACKWARDS INCOMPAT DUE TO TYPE CHANGES IN ARGO 3.6 Signed-off-by: Elliot Gunton <[email protected]>
* Also remove pyi files to fix lint Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
added
semver:minor
A change requiring a minor version bump
type:informational
Provides information or notice to the community
labels
Dec 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
=====================================
Coverage 86.2% 86.3%
=====================================
Files 60 60
Lines 4091 4095 +4
Branches 653 653
=====================================
+ Hits 3530 3534 +4
Misses 391 391
Partials 170 170 ☔ View full report in Codecov by Sentry. |
5 tasks
This was referenced Jan 9, 2025
Manual changes required for #1215 --------- Signed-off-by: Elliot Gunton <[email protected]>
* Used by Container, ContainerNode and Script --------- Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
* Fixes `make test-on-cluster`, but unsure why the service account changed Signed-off-by: Elliot Gunton <[email protected]>
alicederyn
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver:minor
A change requiring a minor version bump
type:informational
Provides information or notice to the community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
pod_gc
onWorkflowTemplate
is not rendered correctly) #1292Description of PR
Updates auto-generated models to Argo 3.6. Note there are a few changes to Hera code which are technically breaking changes (but are very simple for users to change):
resources: Optional[ResourceRequirements]
is nowresources: Optional[VolumeResourceRequirements]
for volumes. The attributes in the classes are the same except forclaims
is removed inVolumeResourceRequirements
. Updated 4 examples that were using thiscluster_name
has been removed inObjectMeta
so is also removed in theWorkflow
class. It was never used by the Argo server (and is explicitly noted as an "ignored" field in the field description inObjectMeta
).The rest are changes in the Argo models (i.e. in
src/hera/workflows/models/io/argoproj/workflow/v1alpha1.py
), that will affect users using the models directly. i.e. They'll be (relatively1) stuck on the currentHera
version until they upgrade Argo to 3.6 if they are using the following classes in Argo<3.6:PodGC
structurally changed - see Hera does not have AW 3.6 types (pod_gc
onWorkflowTemplate
is not rendered correctly) #1292Artifact
prefixstr
)ContainerMixin
so no change on the Hera side)ModelClass.construct
as seen here.