PodGC delete_delay_duration bug Fixed with issue #1292 #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Go struct json Unmarshal. Signed-off-by: 도준혁 <[email protected]>
Jun0922
requested review from
sambhav,
elliotgunton and
alicederyn
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fixed with delete_delay_duration. not Duration class but str only for Go struct json Unmarshal.
Pull Request Checklist
pod_gconWorkflowTemplateis not rendered correctly) #1292Description of PR
Currently, to use pod_gc with workflow, we need to make PodGC class and set
delete_delay_duration. And thisdelete_delay_durationshould be theDurationclass but for Go Unmarshal, it seems to be just string. So I changed some code and the bug fixed. See the following changes.before the commit (v1_1.Duration)
after the commit (str)
As you can see, the error code does not appear on my fastAPI app, and I also can check the pod deleted after around 30s on Pod Success, which means no logs on my argo dashboard.
This PR adds/changes/fixes...