-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gate permissioned signer #15622
base: 10-09-create_benchmark
Are you sure you want to change the base?
Feature gate permissioned signer #15622
Conversation
⏱️ 35m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
60ce91a
to
b99540a
Compare
6494f73
to
2bd4613
Compare
b99540a
to
9060d7b
Compare
2bd4613
to
472be55
Compare
update_sequence: | ||
- FeatureFlag: | ||
enabled: | ||
- permissioned_signer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature flag name in the yaml should be permissionedSigner
to match the enum variant defined in FeatureFlag
. Feature flag names must match exactly between the yaml configuration and the enum definition to ensure proper functionality.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
9060d7b
to
266f326
Compare
472be55
to
18a8c9a
Compare
266f326
to
dceaa7d
Compare
18a8c9a
to
015bf33
Compare
dceaa7d
to
bb73811
Compare
015bf33
to
f9ea87a
Compare
bb73811
to
f90a810
Compare
f9ea87a
to
8148ebc
Compare
d88840b
to
2f50393
Compare
1abf540
to
06c7b2f
Compare
2f50393
to
bb44dff
Compare
06c7b2f
to
0b04c34
Compare
bb44dff
to
eebdf27
Compare
0b04c34
to
701bd90
Compare
eebdf27
to
a44c587
Compare
701bd90
to
dc45a68
Compare
a44c587
to
32f31d4
Compare
dc45a68
to
9f4c26b
Compare
32f31d4
to
1e46c52
Compare
9f4c26b
to
fa00b2b
Compare
1e46c52
to
85ff210
Compare
fa00b2b
to
afcf6ee
Compare
85ff210
to
ce6813c
Compare
afcf6ee
to
3945d58
Compare
ce6813c
to
6d151ac
Compare
3945d58
to
9ea22ad
Compare
6d151ac
to
75c97b0
Compare
9ea22ad
to
b5759d6
Compare
75c97b0
to
37cabc1
Compare
b5759d6
to
7afaedc
Compare
37cabc1
to
3736cdb
Compare
7afaedc
to
2a0df61
Compare
3736cdb
to
406fd4a
Compare
2a0df61
to
a94f57b
Compare
406fd4a
to
e75f27b
Compare
Description
Adds support for permissioned signer functionality in the Aptos framework by introducing a new feature flag
PERMISSIONED_SIGNER
. This change enables controlled access to signer capabilities through permission checks. The implementation includes feature flag assertions in the permissioned signer module to ensure the feature is enabled before use.How Has This Been Tested?
The feature flag implementation follows established patterns used for other feature flags in the system. Testing is enforced through the existing feature flag testing infrastructure.
Key Areas to Review
permissioned_signer.move
signer_from_permissioned_handle
andsigner_from_storable_permissioned_handle
features.move
Type of Change
Which Components or Systems Does This Change Impact?
Checklist