Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate permissioned signer #15622

Open
wants to merge 1 commit into
base: 10-09-create_benchmark
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Dec 17, 2024

Description

Adds support for permissioned signer functionality in the Aptos framework by introducing a new feature flag PERMISSIONED_SIGNER. This change enables controlled access to signer capabilities through permission checks. The implementation includes feature flag assertions in the permissioned signer module to ensure the feature is enabled before use.

How Has This Been Tested?

The feature flag implementation follows established patterns used for other feature flags in the system. Testing is enforced through the existing feature flag testing infrastructure.

Key Areas to Review

  • Feature flag integration in permissioned_signer.move
  • New permission checks added to signer_from_permissioned_handle and signer_from_storable_permissioned_handle
  • Feature flag constant definition and helper functions in features.move

Type of Change

  • New feature
  • Aptos Framework

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine
  • Aptos Framework

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 17, 2024

⏱️ 35m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩
general-lints 58s 🟩🟩
semgrep/ci 57s 🟩🟩
file_change_determinator 32s 🟩🟩
permission-check 10s 🟩🟩
permission-check 6s 🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Dec 17, 2024

@runtian-zhou runtian-zhou marked this pull request as ready for review December 17, 2024 15:20
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 60ce91a to b99540a Compare December 18, 2024 07:37
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 6494f73 to 2bd4613 Compare December 18, 2024 07:37
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from b99540a to 9060d7b Compare January 8, 2025 23:55
@runtian-zhou runtian-zhou requested review from junkil-park, alinush and a team as code owners January 8, 2025 23:55
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 2bd4613 to 472be55 Compare January 8, 2025 23:56
update_sequence:
- FeatureFlag:
enabled:
- permissioned_signer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature flag name in the yaml should be permissionedSigner to match the enum variant defined in FeatureFlag. Feature flag names must match exactly between the yaml configuration and the enum definition to ensure proper functionality.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 9060d7b to 266f326 Compare January 9, 2025 00:55
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 472be55 to 18a8c9a Compare January 9, 2025 00:55
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 266f326 to dceaa7d Compare January 9, 2025 03:44
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 18a8c9a to 015bf33 Compare January 9, 2025 03:44
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from dceaa7d to bb73811 Compare January 9, 2025 07:58
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 015bf33 to f9ea87a Compare January 9, 2025 07:58
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from bb73811 to f90a810 Compare January 10, 2025 18:48
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from f9ea87a to 8148ebc Compare January 10, 2025 18:48
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from d88840b to 2f50393 Compare January 11, 2025 03:43
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 1abf540 to 06c7b2f Compare January 11, 2025 05:07
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 2f50393 to bb44dff Compare January 11, 2025 05:07
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 06c7b2f to 0b04c34 Compare January 12, 2025 23:48
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from bb44dff to eebdf27 Compare January 12, 2025 23:49
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 0b04c34 to 701bd90 Compare January 13, 2025 04:37
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from eebdf27 to a44c587 Compare January 13, 2025 04:37
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 701bd90 to dc45a68 Compare January 13, 2025 04:40
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from a44c587 to 32f31d4 Compare January 13, 2025 04:40
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from dc45a68 to 9f4c26b Compare January 13, 2025 05:57
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 32f31d4 to 1e46c52 Compare January 13, 2025 05:57
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 9f4c26b to fa00b2b Compare January 13, 2025 19:07
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 1e46c52 to 85ff210 Compare January 13, 2025 19:08
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from fa00b2b to afcf6ee Compare January 13, 2025 20:21
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 85ff210 to ce6813c Compare January 13, 2025 20:21
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from afcf6ee to 3945d58 Compare January 13, 2025 20:31
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from ce6813c to 6d151ac Compare January 13, 2025 20:31
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 3945d58 to 9ea22ad Compare January 13, 2025 21:19
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 6d151ac to 75c97b0 Compare January 13, 2025 21:19
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 9ea22ad to b5759d6 Compare January 13, 2025 21:44
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 75c97b0 to 37cabc1 Compare January 13, 2025 21:44
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from b5759d6 to 7afaedc Compare January 13, 2025 22:26
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 37cabc1 to 3736cdb Compare January 13, 2025 22:27
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 7afaedc to 2a0df61 Compare January 13, 2025 23:12
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 3736cdb to 406fd4a Compare January 13, 2025 23:12
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 2a0df61 to a94f57b Compare January 14, 2025 00:24
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 406fd4a to e75f27b Compare January 14, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant