Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permissions for fungible assets operation #14567

Open
wants to merge 1 commit into
base: 08-29-create_permissioned_signer_example
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Sep 9, 2024

Description

Implemented permissions for FA transfer.

  • Work with current Coin that already migrated to FA as well.
  • Implemented a new api deposit_with_signer so that permissions can be added to the signer back again.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Added test cases. In particular, tested the entire migration path of Coin and FA.

Key Areas to Review

Make sure FA permission works well throughout the entire migration path of FA.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 9, 2024

⏱️ 2h 15m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 18m 🟩
rust-move-unit-coverage 15m 🟩
rust-move-unit-coverage 15m 🟩
rust-move-unit-coverage 15m 🟩
general-lints 10m 🟩🟩🟩🟩🟩
check-dynamic-deps 10m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-move-tests 8m 🟥
rust-move-unit-coverage 4m
rust-move-tests 4m
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-tests 3m 🟥
file_change_determinator 1m 🟩🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (7c5a356) to head (bb315dd).

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##           09-04-implement_rust_logics_for_permissioned_signer   #14567   +/-   ##
====================================================================================
  Coverage                                                 60.1%    60.1%           
====================================================================================
  Files                                                      857      857           
  Lines                                                   210762   210762           
====================================================================================
+ Hits                                                    126723   126744   +21     
+ Misses                                                   84039    84018   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6592c01 to 54c34ad Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 54c34ad to 1835d3d Compare September 18, 2024 06:22
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1835d3d to 42decc7 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 42decc7 to 6ac9449 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6ac9449 to 3ae6a87 Compare September 19, 2024 08:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 3ae6a87 to 7fbfa3e Compare October 4, 2024 20:56
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 7fbfa3e to f3015ce Compare October 5, 2024 01:54
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from c447764 to 756ec14 Compare January 12, 2025 23:47
@runtian-zhou runtian-zhou changed the base branch from 09-04-implement_rust_logics_for_permissioned_signer to 08-29-create_permissioned_signer_example January 12, 2025 23:48
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from d90d8d0 to 88d3049 Compare January 13, 2025 04:36
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 88d3049 to 1d9e5be Compare January 13, 2025 04:39
@runtian-zhou runtian-zhou force-pushed the asset_permission branch 2 times, most recently from 5173621 to 5d684fc Compare January 13, 2025 05:57
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 1d9e5be to e6e0643 Compare January 13, 2025 19:06
@@ -31,12 +31,13 @@ spec aptos_framework::aptos_coin {
///
spec module {
pragma verify = true;
pragma aborts_if_is_strict;
pragma aborts_if_is_partial;
Copy link
Contributor

@rahxephon89 rahxephon89 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this module level pragma aborts_if_is_partial leads to verification error, need to add them at the function level. Same for other similar changes in this PR.

@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from e6e0643 to c9f58c6 Compare January 13, 2025 20:29
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from c9f58c6 to 4d4ef05 Compare January 13, 2025 21:18
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 4d4ef05 to 88dd037 Compare January 13, 2025 21:43
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 88dd037 to feadfa6 Compare January 13, 2025 22:25
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from feadfa6 to b593175 Compare January 13, 2025 23:11
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from b593175 to 2546465 Compare January 14, 2025 04:12
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 2546465 to bb7d1e9 Compare January 14, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants