-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add permissions for fungible assets operation #14567
base: 08-29-create_permissioned_signer_example
Are you sure you want to change the base?
add permissions for fungible assets operation #14567
Conversation
⏱️ 2h 15m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-04-implement_rust_logics_for_permissioned_signer #14567 +/- ##
====================================================================================
Coverage 60.1% 60.1%
====================================================================================
Files 857 857
Lines 210762 210762
====================================================================================
+ Hits 126723 126744 +21
+ Misses 84039 84018 -21 ☔ View full report in Codecov by Sentry. |
dec4a79
to
6cd5fd0
Compare
350db4c
to
dad258f
Compare
6cd5fd0
to
88ad9a1
Compare
dad258f
to
6b4da66
Compare
88ad9a1
to
5f90e3a
Compare
6b4da66
to
b1fd015
Compare
5f90e3a
to
ef7be0f
Compare
b1fd015
to
6592c01
Compare
ef7be0f
to
cd6090b
Compare
6592c01
to
54c34ad
Compare
cd6090b
to
0df1c5a
Compare
54c34ad
to
1835d3d
Compare
0df1c5a
to
1bd468b
Compare
1835d3d
to
42decc7
Compare
1bd468b
to
40796a4
Compare
42decc7
to
6ac9449
Compare
40796a4
to
4940d7d
Compare
6ac9449
to
3ae6a87
Compare
4940d7d
to
d8742c4
Compare
3ae6a87
to
7fbfa3e
Compare
d8742c4
to
5d53f18
Compare
7fbfa3e
to
f3015ce
Compare
922af16
to
8dd197a
Compare
c447764
to
756ec14
Compare
8dd197a
to
a59ec35
Compare
d90d8d0
to
88d3049
Compare
a59ec35
to
f4fea6b
Compare
88d3049
to
1d9e5be
Compare
5173621
to
5d684fc
Compare
1d9e5be
to
e6e0643
Compare
5d684fc
to
85e9bbf
Compare
@@ -31,12 +31,13 @@ spec aptos_framework::aptos_coin { | |||
/// | |||
spec module { | |||
pragma verify = true; | |||
pragma aborts_if_is_strict; | |||
pragma aborts_if_is_partial; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this module level pragma aborts_if_is_partial
leads to verification error, need to add them at the function level. Same for other similar changes in this PR.
e6e0643
to
c9f58c6
Compare
85e9bbf
to
e1343de
Compare
c9f58c6
to
4d4ef05
Compare
e1343de
to
915b91d
Compare
4d4ef05
to
88dd037
Compare
915b91d
to
125e5fd
Compare
88dd037
to
feadfa6
Compare
125e5fd
to
2547778
Compare
feadfa6
to
b593175
Compare
2547778
to
fb57ead
Compare
b593175
to
2546465
Compare
fb57ead
to
27f7a9f
Compare
2546465
to
bb7d1e9
Compare
27f7a9f
to
da3c09f
Compare
Description
Implemented permissions for FA transfer.
deposit_with_signer
so that permissions can be added to the signer back again.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added test cases. In particular, tested the entire migration path of Coin and FA.
Key Areas to Review
Make sure FA permission works well throughout the entire migration path of FA.
Checklist