Feat/qp dry run #6656
Merged
Feat/qp dry run #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: fdc6e7bef873059e2b2fe904 URL: https://www.apollographql.com/docs/deploy-preview/fdc6e7bef873059e2b2fe904 |
6 tasks
BrynCooke
approved these changes
Jan 28, 2025
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio backport 1.x |
✅ Backports have been created
|
6 tasks
lleadbet
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duplicating #5826 (and #6635 as it's acting odd due to being a fork) to more easily rebase. This just copies the code needed for the change (specifically the plugin changes). All work done by @lennyburdette and @aaronArinder - I'm just helping get this across the line.
This PR adds a new
dry-runoption to theApollo-Expose-Query-Planheader value that emits the query plans back to Studio for visualizations. This new value will only emit the query plan, and abort execution. This can be helpful for tools likerover, where query plan generation is needed but not full runtime, or for potentially prewarming query plan caches out of band.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
None; this is net new functionality.
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩