Skip to content

fix(banyandb): prevent time range overflow in profile thread snapshot query #13660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 3 commits into from
Jan 13, 2026
+7 −3
Merged

fix(banyandb): prevent time range overflow in profile thread snapshot query #13660

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72155f
fix(banyandb): prevent time range overflow in profile thread snapshot…
Jan 12, 2026
868d35b
fix(banyandb): prevent time range overflow in profile thread snapshot…
Jan 13, 2026
eb88d39
Merge branch 'master' into fix-banyandb
wu-sheng Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...king/oap/server/storage/plugin/banyandb/stream/BanyanDBProfileThreadSnapshotQueryDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public BanyanDBProfileThreadSnapshotQueryDAO(BanyanDBStorageClient client, int p
}

@Override
public List<ProfileThreadSnapshotRecord> queryRecords(String taskId) throws IOException {
public List<ProfileThreadSnapshotRecord> queryRecords(String taskId) throws IOException {
StreamQueryResponse resp = query(false, ProfileThreadSnapshotRecord.INDEX_NAME,
TAGS_BASIC,
new QueryBuilder<StreamQuery>() {
Expand All @@ -97,7 +97,7 @@ public void apply(StreamQuery query) {
List<ProfileThreadSnapshotRecord> result = new ArrayList<>();
for (final RowEntity rowEntity : resp.getElements()) {
ProfileThreadSnapshotRecord record = this.builder.storage2Entity(
new BanyanDBConverter.StorageToStream(ProfileThreadSnapshotRecord.INDEX_NAME, rowEntity));
new BanyanDBConverter.StorageToStream(ProfileThreadSnapshotRecord.INDEX_NAME, rowEntity));
result.add(record);
}
return result;
Expand Down Expand Up @@ -136,8 +136,11 @@ public void apply(StreamQuery query) {
}

private int querySequenceWithAgg(AggType aggType, String segmentId, long start, long end) throws IOException {
// Clamp the time range to safe bounds for BanyanDB
long safeStart = Math.max(start, LOWER_BOUND_TIME);
long safeEnd = Math.min(end, UPPER_BOUND_TIME);
StreamQueryResponse resp = query(false, ProfileThreadSnapshotRecord.INDEX_NAME,
TAGS_ALL, new TimestampRange(start, end),
TAGS_ALL, new TimestampRange(safeStart, safeEnd),
new QueryBuilder<StreamQuery>() {
@Override
public void apply(StreamQuery query) {
Expand Down
Loading