fix(banyandb): prevent time range overflow in profile thread snapshot query #13660
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BanyanDB INVALID_ARGUMENT error when analyzing profile snapshots
Bug Description:
When using BanyanDB as the storage backend and analyzing profile data via the UI, the system throws an
INVALID_ARGUMENTerror:Root Cause:
In
ProfileAnalyzer.analyze(), the Go profile fallback logic passesLong.MAX_VALUEas the end time toqueryMinSequence()andqueryMaxSequence():While this works fine for JDBC storage backends,
BanyanDBProfileThreadSnapshotQueryDAOpasses this value directly toTimestampRange, which BanyanDB server cannot handle as it exceeds the supported time range.Fix:
Clamp the
startandendtime parameters inBanyanDBProfileThreadSnapshotQueryDAO.querySequenceWithAgg()to safe bounds usingLOWER_BOUND_TIMEandUPPER_BOUND_TIMEconstants already defined inAbstractBanyanDBDAO.CHANGESlog.