Skip to content

KAFKA-20163: Missing MM2 default exclude configs #21443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fvaleri wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-20163: Missing MM2 default exclude configs #21443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...ect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ public class DefaultConfigPropertyFilter implements ConfigPropertyFilter {

private static final String CONFIG_PROPERTIES_EXCLUDE_DOC = "List of topic configuration properties and/or regexes "
+ "that should not be replicated.";
public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT = "follower\\.replication\\.throttled\\.replicas, "
+ "leader\\.replication\\.throttled\\.replicas, "
+ "message\\.timestamp\\.difference\\.max\\.ms, "
+ "message\\.timestamp\\.type, "
+ "unclean\\.leader\\.election\\.enable, "
+ "min\\.insync\\.replicas";
public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT = "follower.replication.throttled.replicas, "
+ "leader.replication.throttled.replicas, "
+ "message.timestamp.difference.max.ms, "
+ "log.message.timestamp.before.max.ms, "
+ "log.message.timestamp.after.max.ms, "
+ "message.timestamp.type, "
+ "unclean.leader.election.enable, "
+ "min.insync.replicas";
Comment on lines -38 to +45
Copy link
Contributor Author

@fvaleri fvaleri Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing double backslash before full stops is fine in practice. An unescaped full stop would only cause a false match if there were a config property name identical except with a different character where a dot is (e.g. minXinsync.replicas), which doesn't exist in Kafka's config space. The readability improvement outweighs the theoretical imprecision.

private Pattern excludePattern = MirrorUtils.compilePatternList(CONFIG_PROPERTIES_EXCLUDE_DEFAULT);
private String useDefaultsFrom = USE_DEFAULTS_FROM_DEFAULT;

Expand Down
15 changes: 8 additions & 7 deletions connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,12 +337,14 @@ public void testConfigPropertyFilteringWithAlterConfigsAndSourceDefault() {
@Test
public void testNewTopicConfigs() throws Exception {
Map<String, Object> filterConfig = new HashMap<>();
filterConfig.put(DefaultConfigPropertyFilter.CONFIG_PROPERTIES_EXCLUDE_CONFIG, "follower\\.replication\\.throttled\\.replicas, "
+ "leader\\.replication\\.throttled\\.replicas, "
+ "message\\.timestamp\\.difference\\.max\\.ms, "
+ "message\\.timestamp\\.type, "
+ "unclean\\.leader\\.election\\.enable, "
+ "min\\.insync\\.replicas,"
filterConfig.put(DefaultConfigPropertyFilter.CONFIG_PROPERTIES_EXCLUDE_CONFIG, "follower.replication.throttled.replicas, "
+ "leader.replication.throttled.replicas, "
+ "message.timestamp.difference.max.ms, "
+ "log.message.timestamp.before.max.ms, "
+ "log.message.timestamp.after.max.ms, "
+ "message.timestamp.type, "
+ "unclean.leader.election.enable, "
+ "min.insync.replicas,"
+ "exclude_param.*");
DefaultConfigPropertyFilter filter = new DefaultConfigPropertyFilter();
filter.configure(filterConfig);
Expand Down Expand Up @@ -377,7 +379,6 @@ public void testNewTopicConfigs() throws Exception {
verify(connector).createNewTopics(any(), any());
}


@Test
public void testMirrorSourceConnectorTaskConfig() {
List<TopicPartition> knownSourceTopicPartitions = new ArrayList<>();
Expand Down