KAFKA-20163: Missing MM2 default exclude configs#21443
Open
fvaleri wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20163: Missing MM2 default exclude configs#21443fvaleri wants to merge 1 commit intoapache:trunkfrom
fvaleri wants to merge 1 commit intoapache:trunkfrom
Conversation
This patch adds the following missing configuration in MM2 exclude defaults that were introduced in KIP-937: - log.message.timestamp.before.max.ms - log.message.timestamp.after.max.ms Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
github-actions
bot
added
triage
fvaleri
commented
Feb 10, 2026
Comment on lines
-38
to
+45
| public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT = "follower\\.replication\\.throttled\\.replicas, " | ||
| + "leader\\.replication\\.throttled\\.replicas, " | ||
| + "message\\.timestamp\\.difference\\.max\\.ms, " | ||
| + "message\\.timestamp\\.type, " | ||
| + "unclean\\.leader\\.election\\.enable, " | ||
| + "min\\.insync\\.replicas"; | ||
| public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT = "follower.replication.throttled.replicas, " | ||
| + "leader.replication.throttled.replicas, " | ||
| + "message.timestamp.difference.max.ms, " | ||
| + "log.message.timestamp.before.max.ms, " | ||
| + "log.message.timestamp.after.max.ms, " | ||
| + "message.timestamp.type, " | ||
| + "unclean.leader.election.enable, " | ||
| + "min.insync.replicas"; |
Contributor
Author
There was a problem hiding this comment.
Removing double backslash before full stops is fine in practice. An unescaped full stop would only cause a false match if there were a config property name identical except with a different character where a dot is (e.g. minXinsync.replicas), which doesn't exist in Kafka's config space. The readability improvement outweighs the theoretical imprecision.
Contributor
Author
|
@showuon fyi |
Member
|
Let's wait for the CI build results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the following missing configuration in MM2 exclude
defaults that were introduced in KIP-937:
Reviewers: Luke Chen showuon@gmail.com