Skip to content

HBASE-28284 Fix the NPE that occurs when calling getBootstrapNodes before the HRegionServer has been fully initialized. #6845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiping-tech wants to merge 2 commits into
base: branch-3
Choose a base branch
from
Open

HBASE-28284 Fix the NPE that occurs when calling getBootstrapNodes before the HRegionServer has been fully initialized. #6845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fbb280
HBASE-28284 Fix the NPE that occurs when calling getBootstrapNodes be…
Mar 23, 2025
f3be959
HBASE-28284 Fix the NPE that occurs when calling getBootstrapNodes be…
Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3961,9 +3961,17 @@ public ExecuteProceduresResponse executeProcedures(RpcController controller,
public GetAllBootstrapNodesResponse getAllBootstrapNodes(RpcController controller,
GetAllBootstrapNodesRequest request) throws ServiceException {
GetAllBootstrapNodesResponse.Builder builder = GetAllBootstrapNodesResponse.newBuilder();
server.getBootstrapNodes()
.forEachRemaining(server -> builder.addNode(ProtobufUtil.toServerName(server)));
return builder.build();
try {
checkOpen();
if (server.getBootstrapNodes() == null || !server.getBootstrapNodes().hasNext()) {
throw new IOException("BootstrapNodes are not initialized yet. Please try again later.");
}
server.getBootstrapNodes()
.forEachRemaining(server -> builder.addNode(ProtobufUtil.toServerName(server)));
return builder.build();
} catch (IOException e) {
throw new ServiceException(e);
Copy link
Contributor

@Apache9 Apache9 Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to wrap checkOpen here?

Copy link
Contributor Author

@hiping-tech hiping-tech Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckOpen only ensures that getBootstrapNodes is non-null, but it does not guarantee whether getBootstrapNodes has successfully retrieved the nodes. Therefore, additional validation is needed to ensure completeness.
Please help review this.

}
}

private void setReloadableGuardrails(Configuration conf) {
Expand Down