HBASE-28284 Fix the NPE that occurs when calling getBootstrapNodes before the HRegionServer has been fully initialized.#6845
Open
hiping-tech wants to merge 2 commits intoapache:branch-3from
Open
Conversation
…fore the HRegionServer has been fully initialized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache9
reviewed
Mar 23, 2025
| .forEachRemaining(server -> builder.addNode(ProtobufUtil.toServerName(server))); | ||
| return builder.build(); | ||
| } catch (IOException e) { | ||
| throw new ServiceException(e); |
Contributor
There was a problem hiding this comment.
We only need to wrap checkOpen here?
Contributor
Author
There was a problem hiding this comment.
CheckOpen only ensures that getBootstrapNodes is non-null, but it does not guarantee whether getBootstrapNodes has successfully retrieved the nodes. Therefore, additional validation is needed to ensure completeness.
Please help review this.
…fore the HRegionServer has been fully initialized.
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.