Skip to content

[Bug](distinct) Fixes off-by-one error in aggregation limit check #60828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BiteTheDDDDt wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

[Bug](distinct) Fixes off-by-one error in aggregation limit check #60828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa58594
Fixes off-by-one error in aggregation limit check
BiteTheDDDDt Feb 25, 2026
3ce5fe9
update comment
BiteTheDDDDt Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/pipeline/exec/distinct_streaming_aggregation_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,9 @@ Status DistinctStreamingAggOperatorX::push(RuntimeState* state, vectorized::Bloc

RETURN_IF_ERROR(local_state._distinct_pre_agg_with_serialized_key(
in_block, local_state._aggregated_block.get()));
// set limit and reach limit
// Prevents exceeding the row limit when the aggregated block reaches or equals the threshold.
if (_limit != -1 &&
(local_state._num_rows_returned + local_state._aggregated_block->rows()) > _limit) {
(local_state._num_rows_returned + local_state._aggregated_block->rows()) >= _limit) {
auto limit_rows = _limit - local_state._num_rows_returned;
local_state._aggregated_block->set_num_rows(limit_rows);
local_state._reach_limit = true;
Expand Down
Loading