[Bug](distinct) Fixes off-by-one error in aggregation limit check#60828
[Bug](distinct) Fixes off-by-one error in aggregation limit check#60828BiteTheDDDDt wants to merge 2 commits intoapache:masterfrom
Conversation
Updates limit condition to ensure exactly the specified number of rows are returned. Prevents exceeding the row limit when the aggregated block reaches or equals the threshold.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
There was a problem hiding this comment.
Pull request overview
Fixes an off-by-one condition in distinct streaming aggregation to ensure the operator does not emit more than the configured row limit.
Changes:
- Adjusts the limit reach condition from
>to>=when evaluatingnum_rows_returned + aggregated_block->rows()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
What problem does this PR solve?
Updates limit condition to ensure exactly the specified number of rows are returned. Prevents exceeding the row limit when the aggregated block reaches or equals the threshold.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)