-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Postgres's LOCK TABLE statement #1614
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> { | |
top = Some(self.parse_top()?); | ||
} | ||
|
||
let projection = self.parse_projection()?; | ||
let projection = if dialect_of!(self is PostgreSqlDialect | GenericDialect) | ||
&& self.peek_keyword(Keyword::FROM) | ||
{ | ||
vec![] | ||
} else { | ||
self.parse_projection()? | ||
}; | ||
Comment on lines
+9607
to
+9613
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can probably skip these changes in this PR given it's now in #1613? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @iffyio oh my bad - I should have branched from the apache |
||
|
||
let into = if self.parse_keyword(Keyword::INTO) { | ||
let temporary = self | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we take a look at merging this into the existing
Statement::LockTables
variant? I think that would be the desirable path forward in order to avoid duplicating the statement typeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try doing that. FWIW the reason I didn't to begin with is that at it seemed like the MySQL version of the
LOCK ...
statement is quite different to PG's, but I didn't think too hard about it.