Parse Postgres's LOCK TABLE statement #1614
Open
+168
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle empty projection for pg
See: https://www.postgresql.org/docs/current/sql-lock.html PG's full syntax for this statement is supported: ``` LOCK [ TABLE ] [ ONLY ] name [ * ] [, ...] [ IN lockmode MODE ] [ NOWAIT ] where lockmode is one of: ACCESS SHARE | ROW SHARE | ROW EXCLUSIVE | SHARE UPDATE EXCLUSIVE | SHARE | SHARE ROW EXCLUSIVE | EXCLUSIVE | ACCESS EXCLUSIVE ``` It is implemented to not intefere with the roughly equivalent (but different) syntax in MySQL, by using a new Statement variant.
freshtonic
force-pushed
the
james/cip-1063-add-lock-table-support-in-sqlparser
branch
from
7ce8f33 to
47a3e5e
Compare
iffyio
reviewed
Dec 21, 2024
Comment on lines
+9607
to
+9613
| let projection = if dialect_of!(self is PostgreSqlDialect | GenericDialect) | ||
| && self.peek_keyword(Keyword::FROM) | ||
| { | ||
| vec![] | ||
| } else { | ||
| self.parse_projection()? | ||
| }; |
| /// | SHARE | SHARE ROW EXCLUSIVE | EXCLUSIVE | ACCESS EXCLUSIVE | ||
| /// | ||
| /// Note: this is a Postgres-specific statement. See <https://www.postgresql.org/docs/current/sql-lock.html> | ||
| LockTablesPG { |
There was a problem hiding this comment.
Could we take a look at merging this into the existing Statement::LockTables variant? I think that would be the desirable path forward in order to avoid duplicating the statement type
There was a problem hiding this comment.
I'll try doing that. FWIW the reason I didn't to begin with is that at it seemed like the MySQL version of the LOCK ... statement is quite different to PG's, but I didn't think too hard about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.postgresql.org/docs/current/sql-lock.html
PG's full syntax for this statement is supported:
It is implemented to not intefere with the roughly equivalent (but different) syntax in MySQL, by using a new Statement variant.