GH-47720: [C++][FlightRPC] ODBC Columns Metadata #48049
Open
+994
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
commented
Nov 4, 2025
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Nov 6, 2025
github-actions
bot
added
awaiting merge
alinaliBQ
changed the title
alinaliBQ
force-pushed
the
gh-47720-sql-columns
branch
2 times, most recently
from
082eb6e to
9507ee2
Compare
alinaliBQ
force-pushed
the
gh-47720-sql-columns
branch
2 times, most recently
from
378a314 to
18f8939
Compare
lidavidm
approved these changes
Dec 11, 2025
Comment on lines
+185
to
+187
| if (skipping_test_) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Used for checking if the environment variable ARROW_FLIGHT_SQL_ODBC_CONN exists. If it doesn't exist, skipping_test_ is set to true and the test is skipped.
jduo
approved these changes
Dec 12, 2025
Co-Authored-By: alinalibq <[email protected]>
All issues mentioned in the TODO comments are completed. We forgot to remove the comments
alinaliBQ
force-pushed
the
gh-47720-sql-columns
branch
from
94c9e99 to
e0cd3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add support for returning columns metadata from the connected data source.
What changes are included in this PR?
Are these changes tested?
Tested in local MSVC
Are there any user-facing changes?
N/A