Skip to content

Commit e0cd3b8

Browse files
committed
Clean up old TODO comments
All issues mentioned in the TODO comments are completed. We forgot to remove the comments
1 parent 7c0e6c6 commit e0cd3b8

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,7 @@ SQLRETURN SQLAllocHandle(SQLSMALLINT type, SQLHANDLE parent, SQLHANDLE* result)
4141
ARROW_LOG(DEBUG) << "SQLAllocHandle called with type: " << type
4242
<< ", parent: " << parent
4343
<< ", result: " << static_cast<const void*>(result);
44-
// GH-47706 TODO: Add tests for SQLAllocStmt, pre-requisite requires
45-
// SQLDriverConnect implementation
46-
4744
*result = nullptr;
48-
4945
switch (type) {
5046
case SQL_HANDLE_ENV: {
5147
using ODBC::ODBCEnvironment;
@@ -141,9 +137,6 @@ SQLRETURN SQLAllocHandle(SQLSMALLINT type, SQLHANDLE parent, SQLHANDLE* result)
141137
SQLRETURN SQLFreeHandle(SQLSMALLINT type, SQLHANDLE handle) {
142138
ARROW_LOG(DEBUG) << "SQLFreeHandle called with type: " << type
143139
<< ", handle: " << handle;
144-
// GH-47706 TODO: Add tests for SQLFreeStmt, pre-requisite requires
145-
// SQLAllocStmt tests
146-
147140
switch (type) {
148141
case SQL_HANDLE_ENV: {
149142
using ODBC::ODBCEnvironment;
@@ -234,7 +227,6 @@ SQLRETURN SQLFreeStmt(SQLHSTMT handle, SQLUSMALLINT option) {
234227
}
235228

236229
case SQL_UNBIND: {
237-
// GH-47716 TODO: Add tests for SQLBindCol unbinding
238230
using ODBC::ODBCDescriptor;
239231
using ODBC::ODBCStatement;
240232
return ODBCStatement::ExecuteWithDiagnostics(handle, SQL_ERROR, [=]() {
@@ -280,7 +272,6 @@ SQLRETURN SQLGetDiagField(SQLSMALLINT handle_type, SQLHANDLE handle,
280272
<< ", diag_info_ptr: " << diag_info_ptr
281273
<< ", buffer_length: " << buffer_length << ", string_length_ptr: "
282274
<< static_cast<const void*>(string_length_ptr);
283-
// GH-46575 TODO: Add tests for SQLGetDiagField
284275
using ODBC::GetStringAttribute;
285276
using ODBC::ODBCConnection;
286277
using ODBC::ODBCDescriptor;
@@ -545,7 +536,6 @@ SQLRETURN SQLGetDiagRec(SQLSMALLINT handle_type, SQLHANDLE handle, SQLSMALLINT r
545536
<< ", message_text: " << static_cast<const void*>(message_text)
546537
<< ", buffer_length: " << buffer_length
547538
<< ", text_length_ptr: " << static_cast<const void*>(text_length_ptr);
548-
// GH-46575 TODO: Add tests for SQLGetDiagRec
549539
using arrow::flight::sql::odbc::Diagnostics;
550540
using ODBC::GetStringAttribute;
551541
using ODBC::ODBCConnection;

0 commit comments

Comments
 (0)