Skip to content

[Hotfix] Fix optimizer group not updated on table refresh #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j1wonpark wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −2
Open

[Hotfix] Fix optimizer group not updated on table refresh #4076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,9 @@ public DefaultTableRuntime refresh(AmoroTable<?> table) {
TableConfiguration newConfiguration = TableConfigurations.parseTableConfig(tableConfig);
TableConfiguration oldConfiguration = getTableConfiguration();
boolean configChanged = !newConfiguration.equals(oldConfiguration);
Copy link
Member

@klion26 klion26 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the configChanged has never been used, maybe we can return immediately if configChanged is false?

String newGroupName = newConfiguration.getOptimizingConfig().getOptimizerGroup();

if (!Objects.equals(
getGroupName(), newConfiguration.getOptimizingConfig().getOptimizerGroup())) {
if (!Objects.equals(getGroupName(), newGroupName)) {
if (optimizingProcess != null) {
optimizingProcess.close(false);
}
Expand All @@ -327,6 +327,7 @@ public DefaultTableRuntime refresh(AmoroTable<?> table) {
config.clear();
config.putAll(tableConfig);
})
.updateGroup(g -> newGroupName)
.updateState(
OPTIMIZING_STATE_KEY,
s -> {
Expand Down
43 changes: 43 additions & 0 deletions amoro-ams/src/test/java/org/apache/amoro/server/table/TestDefaultTableRuntimeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,49 @@ public void testInitialize() throws Exception {
tableService = null;
}

@Test
public void testRefreshUpdatesOptimizerGroup() throws Exception {
tableService =
new DefaultTableService(new Configurations(), CATALOG_MANAGER, runtimeFactoryManager);
TestHandler handler = new TestHandler();
tableService.addHandlerChain(handler);
tableService.initialize();
if (!(catalogTestHelper().tableFormat().equals(TableFormat.MIXED_HIVE)
&& TEST_HMS.getHiveClient().getDatabase(TableTestHelper.TEST_DB_NAME) != null)) {
createDatabase();
}
createTable();

ServerTableIdentifier tableId = tableManager().listManagedTables().get(0);
DefaultTableRuntime runtime = getDefaultTableRuntime(tableId.getId());

// Verify initial group name is "default"
String initialGroup = runtime.getGroupName();
Assert.assertEquals(TableProperties.SELF_OPTIMIZING_GROUP_DEFAULT, initialGroup);

// Change optimizer group property
String newGroupName = "new-optimizer-group";
MixedTable mixedTable = (MixedTable) tableService().loadTable(tableId).originalTable();
mixedTable.updateProperties().set(TableProperties.SELF_OPTIMIZING_GROUP, newGroupName).commit();

// Refresh the runtime
runtime.refresh(tableService.loadTable(tableId));

// Verify that getGroupName() returns the new group name
Assert.assertEquals(newGroupName, runtime.getGroupName());

// Verify config changed handler was called
Assert.assertEquals(1, handler.getConfigChangedTables().size());

// Cleanup
dropTable();
dropDatabase();
tableService.dispose();
MetricManager.dispose();
EventsManager.dispose();
tableService = null;
}

protected DefaultTableService tableService() {
if (tableService != null) {
return tableService;
Expand Down