[Hotfix] Fix optimizer group not updated on table refresh#4076
Open
j1wonpark wants to merge 1 commit intoapache:masterfrom
Open
[Hotfix] Fix optimizer group not updated on table refresh#4076j1wonpark wants to merge 1 commit intoapache:masterfrom
j1wonpark wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: j1wonpark <jpark92@outlook.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When the
self-optimizing.groupproperty of a table is changed (either directly or through catalog default settings), thegroup_namecolumn in thetable_runtimedatabase table is not updated during table refresh. This causes:handleConfigChanged()uses stalegroup_namefrom DB for queue bindingpendingstatus permanently when the original optimizer group no longer existsRoot Cause:
DefaultTableRuntime.refresh()method was missingupdateGroup()call in the store transaction.Brief change log
updateGroup(g -> newGroupName)call inrefresh()method to update thegroup_namecolumn in DB when optimizer group changestestRefreshUpdatesOptimizerGroup()test to verify thatgetGroupName()returns the new group name after refreshHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation