Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 #5602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEAT: Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 #5602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ansys/aedt/core/application/design_solutions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
"DCBiasedEddyCurrent": {
"name": "DCBiasedEddyCurrent",
"options": None,
"report_type": "EddyCurrent",
"default_setup": 60,
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
"Transient": {
"name": "Transient",
"options": None,
Expand Down
43 changes: 41 additions & 2 deletions src/ansys/aedt/core/modules/setup_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,37 @@
)
"""Maxwell eddy current setup properties and default values."""

DCBiasedEddyCurrent = dict(
{
"Enabled": True,
"MeshLink": meshlink,
"MaximumPasses": 6,
"MinimumPasses": 1,
"MinimumConvergedPasses": 1,
"PercentRefinement": 30,
"SolveFieldOnly": False,
"PercentError": 1,
"SolveMatrixAtLast": True,
"UseIterativeSolver": False,
"RelativeResidual": 1e-5,
"NonLinearResidual": 0.0001,
"SmoothBHCurve": False,
"Frequency": "60Hz",
"HasSweepSetup": False,
"SweepRanges": subranges,
"UseHighOrderShapeFunc": False,
"UseMuLink": False,
"DCPercentRefinement": 30,
"DCMinimumPasses": 2,
"DCMinConvergedPasses": 1,
"DCNonLinearResidual": 0.001,
"DCSmoothBHCurve": True,
"DCMaxmumPasses": 10,
"DCPercentError": 1,
}
)


ElectricTransient = dict(
{
"Enabled": True,
Expand Down Expand Up @@ -1833,6 +1864,7 @@
"MechTransientThermal",
"DCConduction",
"ACConduction",
"DCBiasedEddyCurrent",
]

SetupTemplates = {
Expand Down Expand Up @@ -1911,6 +1943,9 @@
37: TransientTemperatureOnly_241,
38: TransientFlowOnly_241,
}
SetupTemplates_251 = {
60: DCBiasedEddyCurrent,
}

@staticmethod
def _add_to_template(template_in, template_to_append):
Expand All @@ -1924,7 +1959,12 @@
from ansys.aedt.core.generic.general_methods import settings

template = SetupKeys.SetupTemplates
if settings.aedt_version is not None and settings.aedt_version >= "2024.1":
if settings.aedt_version is not None and settings.aedt_version >= "2025.1":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the code with the following snippet ? It should make the code more readable and avoid future copy paste errors

        if settings.aedt_version is not None:
            if settings.aedt_version >= "2023.1":
                template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
            if settings.aedt_version >= "2023.2":
                template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
            if settings.aedt_version >= "2024.1":
                template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
            if settings.aedt_version >= "2025.1":
                template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_251)

template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_251)

Check warning on line 1966 in src/ansys/aedt/core/modules/setup_templates.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/modules/setup_templates.py#L1963-L1966 

Added lines #L1963 - L1966 were not covered by tests
elif settings.aedt_version is not None and settings.aedt_version >= "2024.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
Expand All @@ -1933,7 +1973,6 @@
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
elif settings.aedt_version is not None and settings.aedt_version >= "2023.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)

return template

def get_default_icepak_template(self, default_type):
Expand Down
Loading