-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 #5602
base: main
Are you sure you want to change the base?
Conversation
… corresponding setup_templates.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5602 +/- ##
==========================================
- Coverage 85.27% 85.27% -0.01%
==========================================
Files 152 152
Lines 61016 61023 +7
==========================================
+ Hits 52030 52035 +5
- Misses 8986 8988 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left a minor comment :)
@@ -1924,7 +1959,12 @@ def get_setup_templates(): | |||
from ansys.aedt.core.generic.general_methods import settings | |||
|
|||
template = SetupKeys.SetupTemplates | |||
if settings.aedt_version is not None and settings.aedt_version >= "2024.1": | |||
if settings.aedt_version is not None and settings.aedt_version >= "2025.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the code with the following snippet ? It should make the code more readable and avoid future copy paste errors
if settings.aedt_version is not None:
if settings.aedt_version >= "2023.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
if settings.aedt_version >= "2023.2":
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
if settings.aedt_version >= "2024.1":
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
if settings.aedt_version >= "2025.1":
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_251)
Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 and corresponding setup_templates.py
Description
AEDT 25R1 has introduced EddyCurrent with DC Solution new solution type.
Fix #5580
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist