Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing toolchain #1526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −30
Open

Removing toolchain #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions JetLagged/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ android {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
kotlinOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this or kotlin will default to 1.8

jvmTarget = "17"
}
buildFeatures {
compose = true
// Disable unused AGP features
Expand Down
4 changes: 0 additions & 4 deletions JetNews/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ android {
}
}

kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

kotlinOptions {
    jvmTarget = "17"
}

or it will default to 1.8

jvmToolchain(17)
}

dependencies {
val composeBom = platform(libs.androidx.compose.bom)
implementation(composeBom)
Expand Down
4 changes: 1 addition & 3 deletions Jetcaster/core/domain-testing/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing jvmTarget (see other comments)

jvmToolchain(17)
}

dependencies {
implementation(projects.core.domain)

Expand Down
4 changes: 1 addition & 3 deletions Jetcaster/core/domain/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing jvmTarget (see other comments)

jvmToolchain(17)
}

dependencies {
coreLibraryDesugaring(libs.core.jdk.desugaring)
implementation(projects.core.data)
Expand Down
3 changes: 0 additions & 3 deletions Jetcaster/glancewidget/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ android {
}
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing jvmTarget (see other comments)

jvmToolchain(17)
}

dependencies {

Expand Down
4 changes: 1 addition & 3 deletions Jetcaster/tv/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ android {
}
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing jvmTarget (see other comments)

jvmToolchain(17)
}


dependencies {
implementation(libs.androidx.core.ktx)
Expand Down
4 changes: 1 addition & 3 deletions Jetcaster/wear/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ android {
}
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ok - jvmTarget is specified above)

jvmToolchain(17)
}

dependencies {


Expand Down
3 changes: 0 additions & 3 deletions Jetchat/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ android {
}
}

kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing jvmTarget (see other comments)

jvmToolchain(17)
}
dependencies {
val composeBom = platform(libs.androidx.compose.bom)
implementation(composeBom)
Expand Down
2 changes: 0 additions & 2 deletions Jetsnack/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}

kotlinOptions { jvmTarget = "17" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this


buildFeatures {
compose = true
}
Expand Down
3 changes: 0 additions & 3 deletions Reply/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ android {
compose = true
}
}
kotlin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ok - jvmTarget specified above)

jvmToolchain(17)
}

dependencies {
val composeBom = platform(libs.androidx.compose.bom)
Expand Down
Loading