Removing toolchain #1526
Removing toolchain #1526
Conversation
riggaroo
requested review from
dturner and
javadude
and removed request for
dturner
There was a problem hiding this comment.
A few general notes:
-
jvmToolchainacts as a default forsourceCompatibility,targetCompatibility, andjvmTarget. If we usedjvmToolchain, the others aren't needed. (Which is one reason I likedjvmToolchain- one place to specify) -
If we don't have
jvmToolchainorjvmTarget, Kotlin defaults to target 1.8. So whenjvmToolchainis removed,jvmTargetmust be added if not there. (Some scripts had already it) -
Some files didn't have
jvmToolchainand it looks like you accidentally removedjvmTarget -
A nit - one script uses
jvmTarget = JavaVersion.VERSION_17.majorVersionI'd just change that to "17"
| @@ -74,9 +74,6 @@ android { | |||
| sourceCompatibility = JavaVersion.VERSION_17 | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| } | |||
| kotlinOptions { | |||
There was a problem hiding this comment.
Keep this or kotlin will default to 1.8
| @@ -77,10 +77,6 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| kotlin { | |||
There was a problem hiding this comment.
Add
kotlinOptions {
jvmTarget = "17"
}or it will default to 1.8
| @@ -29,9 +29,7 @@ android { | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
missing jvmTarget (see other comments)
| @@ -31,9 +31,7 @@ android { | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
missing jvmTarget (see other comments)
| @@ -36,9 +36,6 @@ android { | |||
| } | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
missing jvmTarget (see other comments)
| @@ -81,9 +81,7 @@ android { | |||
| } | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
missing jvmTarget (see other comments)
| @@ -69,9 +69,7 @@ android { | |||
| } | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
(ok - jvmTarget is specified above)
| @@ -79,9 +79,6 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| kotlin { | |||
There was a problem hiding this comment.
missing jvmTarget (see other comments)
| @@ -78,8 +78,6 @@ android { | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| } | |||
|
|
|||
| kotlinOptions { jvmTarget = "17" } | |||
| @@ -93,9 +93,6 @@ android { | |||
| compose = true | |||
| } | |||
| } | |||
| kotlin { | |||
There was a problem hiding this comment.
(ok - jvmTarget specified above)
No description provided.