Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies and code accordingly #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tegner
Copy link

@tegner tegner commented Jun 27, 2019

I was having trouble with this module after updating my other dependencies.

The problems were specific to core-js and the way it was included.

But I thought a thorough update of dependencies would help.

@felixmagnus
Copy link

We ran into this issue recently.
This would adress #88.
👍 for accepting this pull request.

@coltonmccormack
Copy link

@andreassolberg can we get this pull request approved? A fresh install of JSO throws errors without it.

@VenkataJanapareddy
Copy link

@andreassolberg As of now every project that has core-js v3+ as a dependency is not able to use JSO. This pr will solve that. Can we please get this approved?

@dosstx
Copy link

dosstx commented Mar 10, 2020

Can we use this somehow in our projects ? If so, how would I update this plugin to use the updated files? Thank you

@tegner
Copy link
Author

tegner commented Mar 11, 2020

Can we use this somehow in our projects ? If so, how would I update this plugin to use the updated files? Thank you

I have now published a package with the only change being the updated dependencies

https://www.npmjs.com/package/jso-2

@dosstx
Copy link

dosstx commented Mar 11, 2020

Can you guys walk me through how to update my copy of jso to the one with the updated dependencies? I thought I would run npm remove jso and then do npm i jso-2 but that won't work, will it?

Update: Ok, so i had to change my import statement from import { JSO } from 'jso' to import {JSO} from 'jso-2' . That seems to work now. Thanks you guys! Btw, I"m using latest Vue-Cli.

@unhammer
Copy link

unhammer commented Aug 5, 2020

This PR changes quite a few unrelated things though (style changes etc. in JSO.js). @tegner maybe better to submit one that only updates the deps, and do a separate PR for the stylistic stuff? Would make it easier on @andreassolberg to review.

@dosstx
Copy link

dosstx commented Jun 2, 2021

Any progress on this? Or, anyone have suggestions on an alternate package that would allow us to use a custom provider rather than Facebook, Google, etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants