Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for core-js 3+ #110

Open
VenkataJanapareddy opened this issue Dec 18, 2019 · 1 comment
Open

Support for core-js 3+ #110

VenkataJanapareddy opened this issue Dec 18, 2019 · 1 comment

Comments

@VenkataJanapareddy
Copy link

VenkataJanapareddy commented Dec 18, 2019

Im using JSO in a Vue app built using vue-cli(v4.0.0) which has core-js (v3.3.2) as a dependency. But JSO is using core-js (v2.x.x). Hence , Im getting the following error.

These dependencies were not found:

* core-js/fn/array/includes in ./node_modules/jso/src/JSO.js
* core-js/fn/object/assign in ./node_modules/jso/src/JSO.js
* core-js/fn/promise in ./node_modules/jso/src/JSO.js

core-js has moved the above from core-js/fn to core-js/es. If I downgrade my core-js version to 2.x, the vue-cli wont work. Can we get support for core-js 3 since 2.x is deprecated?

@dosstx
Copy link

dosstx commented Mar 19, 2020

This pull request fixed the issue (for now):

#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants