Home

Welcome to the ah-frontend-dojo wiki!

This web application serves as a project for simulations

Checklist For Reviewing Pull Requests

---

Code analysis

• Does my code follow the team's convention as regards

  1. Namings

     Do my variables, functions, classnames, test titles, components, and filenames perfectly describe what they are meant to do?

  2. Ordering

     Are my imports appropriately ordered as outlined in the wiki?

     Are my CSS properties appropriately ordered as outlined in the wiki?

• Did I follow the best practices as stated in the wiki when writing my components and functions?

• Did I repeat any code that could have been abstracted and concise?

• Is there a section of code that I could have made re-usable?

• Is my code properly documented?

• Did I re-invent the wheel for any section of code instead of leveraging existing functionality?

Branch

• Did I rebase my branch from develop to avoid conflict?
• Does my branch name pattern match with the team's branch naming convention?

Commit Message

• Does my PR have more than five commit messages? If yes, are all of them necessary or can they be squashed to be less than 5 key commits?
• Does my commit message follow the outlined team convention in the engineering playbook?

Pull Request

• Does my PR title match the outlined team convention in the engineering playbook?

Tests and Checks

• Are my tests passing on my local machine and on TravisCI?
• Are my tests displaying errors on the console?
• Does Code Climate check my code as All good?
• Are all the checks on my PR marked as successful?

Labels

• Does my PR have a Finished label attached to it?

Conflicts

• Does my PR conflict with the develop branch? If yes, Resolve it immediately!