-
Notifications
You must be signed in to change notification settings - Fork 7
Git Convetions
Kato Charles edited this page May 27, 2019
·
1 revision
For all commit messages, Pull Requests and Branch naming, devs are required to follow the Engineering playbook for conventions.
For chores, however, in the commit message footer, devs should use [Maintains #STORY_ID]
as opposed to [Starts #STORY_ID]
. This is so because a chore maintains the overall functionality of a feature while improving the quality of the feature.
When a chore is finished, the commit message footer should remain [Maintains #STORY_ID]
and not [Finishes #STORY_ID]
. This is because with chores, Finishes
will auto-deliver the chore without the TTL first approving it.
The TTL will be the only person allowed to change the value from Maintains
to Finishes
only when the dev has reviewed and rubber stamped the chore.