Initial skeleton

[S-Dafarra]

No description provided.

[S-Dafarra]

Thanks @traversaro. Waiting also for @diegoferigo approval since I inherited the structure from https://github.com/ami-iit/rod

[traversaro]

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

[S-Dafarra]

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Ah, you mean this part https://github.com/ami-iit/stepwise/blob/fab37f0aef4d67002258633eea2ddfde8027d962/.github/workflows/ci_cd.yml#L12-L46 ?

[traversaro]

Yes.

[diegoferigo]

Few comments here and there, approving in any case.

[diegoferigo]

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Related to the very old activity I've never finalized ami-iit/bipedal-locomotion-framework#296.

[S-Dafarra]

After removing the packaging section, the CI/CD file is broken because of this line

hippopt/.github/workflows/ci_cd.yml

Line 14 in 7cff695

needs: package

[S-Dafarra]

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

[traversaro]

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

[diegoferigo]

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

[S-Dafarra]

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

I think it is necessary for

hippopt/.github/workflows/ci_cd.yml

Lines 72 to 83 in 170169d

	- name: Download Python packages
	uses: actions/download-artifact@v3
	with:
	path: dist
	name: dist
	- name: Install wheel
	shell: bash
	run: pip install dist/*.whl
	- name: Import the package
	run: python -c "import hippopt"

[diegoferigo]

Sorry @S-Dafarra the file in this PR keeps changing and it's difficult to point to a section. I had a better look to the workflow. I agree with @traversaro, we can remove/comment out the entire publish job. I forgot the workflow has a test job that already pulls the artifact and tests the wheel.

For what regards deployment to PyPI, we should discuss it separately since there might be limitations in the current dependencies that are on PyPI (particularly the casadi wheel, and blf if we want to use it).

[diegoferigo]

Approving, just the last leftover.

Lastly, you can consider specifying the citation in a CITATION.cff file.

[S-Dafarra]

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

[S-Dafarra]

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

I did not find anything, but I also noticed that bib files should be supported too: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files#other-citation-files

[S-Dafarra]

All green. Squashing and merging