Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch token prices & history using new Explorer BE endpoints (rebased and fixed) #322
Fetch token prices & history using new Explorer BE endpoints (rebased and fixed) #322
Changes from 30 commits
98916f1
2ecc943
4e44bf2
8eb05e2
2c59a1d
212403d
a0f950b
4652961
d2636e9
a460bc5
69010c2
0d112f7
a29e363
d1e8d6a
b227159
a886c41
7cc0dce
6d67be6
1bf54bb
d1242be
00e613f
f6af0fe
00bbca3
d150ad2
7884e32
8247702
22a7ee7
8d653e1
4c65e46
6bb9058
65f9b8b
bd02a50
af533a9
c04f2cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly linked to this PR but this could be extracted as well (I actually thought it was already). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed later:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, why should we re-declare them? We can easily click on the constant in our IDEs and navigate to the source where we could have the comments that you mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it pretty useful to see the list of constants actually in use in the project, makes it easier to know what can be tweaked. But yeah, it's a bit more maintenance involved.