-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch token prices & history using new Explorer BE endpoints (rebased and fixed) #322
Conversation
🦋 Changeset detectedLatest commit: c04f2cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fea79dd
to
0ea9f05
Compare
0ea9f05
to
a3e577c
Compare
75cdbf0
to
8c03dde
Compare
8c03dde
to
1bf54bb
Compare
e3147ff
to
0dbc4f9
Compare
0dbc4f9
to
8247702
Compare
6334164
to
6bb9058
Compare
apps/desktop-wallet/src/pages/UnlockedWallet/OverviewPage/AmountsOverviewPanel.tsx
Show resolved
Hide resolved
apps/desktop-wallet/src/storage/addresses/addressesSelectors.ts
Outdated
Show resolved
Hide resolved
Related to #243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! 👏
@@ -30,7 +30,9 @@ import { | |||
|
|||
const PAGE_LIMIT = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly linked to this PR but this could be extracted as well (I actually thought it was already). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed later:
- For maintainability sake, we could use comments to describe what each constant does.
- Some constants would be in SHRD, those ones should IMO be imported and re-declared in each sub-package for clarity, instead of being imported directly in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, why should we re-declare them? We can easily click on the constant in our IDEs and navigate to the source where we could have the comments that you mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it pretty useful to see the list of constants actually in use in the project, makes it easier to know what can be tweaked. But yeah, it's a bit more maintenance involved.
apps/desktop-wallet/src/pages/UnlockedWallet/AddressesPage/AddressGridRow.tsx
Show resolved
Hide resolved
apps/desktop-wallet/src/pages/UnlockedWallet/OverviewPage/AmountsOverviewPanel.tsx
Show resolved
Hide resolved
Testing, everything looks pretty good. As expected, I'm not really happy with the amount / price history situation (lack of), but it's a temporary thing :) |
This is @mvaivre's initial PR, rebased.
Fixes most subtasks of #243.
@nop33's subtasks:
master
and improve if needed