migrate to aio-lib-ims. fixes #129 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 99.63% 99.89% +0.25%
==========================================
Files 30 42 +12
Lines 829 963 +134
Branches 65 97 +32
==========================================
+ Hits 826 962 +136
+ Misses 3 1 -2
Continue to review full report at Codecov.
|
justinedelson
force-pushed
the
issue/migrate-to-aio-lib-ims
branch
from
2ebcf27
to
5f240f5
Compare
justinedelson
force-pushed
the
issue/migrate-to-aio-lib-ims
branch
from
1dcc507
to
e4cfa8e
Compare
justinedelson
force-pushed
the
issue/migrate-to-aio-lib-ims
branch
3 times, most recently
from
935235a
to
79593af
Compare
…dobe/aio-lib-ims fixes #129 BREAKING CHANGE: private key passphrases are no longer supported
justinedelson
force-pushed
the
issue/migrate-to-aio-lib-ims
branch
from
79593af
to
b6da45f
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the deprecated @adobe/aio-cli-plugin-jwt-auth with @adobe/aio-lib-ims.
This is a breaking change because of the lack of passphrase support in @adobe/aio-lib-ims. All other configurations should be migrated successfully.
Related Issue
#129
Motivation and Context
Deprecation of dependency
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: