Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lib core config #126

Closed
wants to merge 1 commit into from
Closed

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Jul 7, 2020

Description

see #124

the lib core config version < 2 is using patch-package which is considerably increasing the size of the module see: adobe/aio-lib-core-config#27 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #126 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          26       26           
  Lines         923      923           
  Branches      115      115           
=======================================
  Hits          859      859           
  Misses         58       58           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4162e5...a536e67. Read the comment docs.

},
"dependencies": {
"@adobe/aio-lib-core-config": {
"version": "1.2.8",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinedelson @adobe/aio-cli-plugin-jwt-auth is still dependent on config 1.x.x, and https://github.com/adobe/aio-cli-plugin-jwt-auth is archived in favor of @adobe/aio-cli-plugin-auth or @adobe/aio-lib-ims (recommended to depend on a lib and not a plugin in a plugin)

Copy link
Member

@justinedelson justinedelson Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moritzraho is there a migration guide from aio-cli-plugin-jwt-auth to aio-lib-ims? It seems like there's no real point in doing this change until aio-cli-plugin-jwt-auth is removed.

@justinedelson
Copy link
Member

This has been incorporated into #130

@justinedelson justinedelson marked this pull request as draft November 17, 2020 23:31
@justinedelson
Copy link
Member

This was actually done a while ago and I finally did the update to lib-ims. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants