Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managers can add notes and set status of reports #139

Merged
merged 7 commits into from
Feb 4, 2021

Conversation

jasalisbury
Copy link

Description of change

  • Review page is now different if the user looking at the page is the approving manager
  • Manager's review page includes the user's additional note and allows the manager to leave a manager note
  • Manager note added to DB
  • Report state is shown in the side nav's "review" section once it leaves "draft" mode
  • Policy, service and route added to update status of a report

How to test

  1. Pull down, run migrations/seeders
  2. Make sure the CURRENT_USER_ID is set to "1"
  3. Fill out a complete report. Add "Hermione" as the approving manager
  4. Refresh the report, since Hermione is user with the id 1 you should see the approving manager version of the review page.
  5. Add a manager note and set the status. Note once you submit the status on the side nav Review and submit section updates
  6. Refresh the page to verify the manager notes persists

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

 * Review page is now different if the user looking at the page is the
approving manager
 * Manager's review page includes the user's additional note and allows
the manager to leave a manager note
 * Manager note added to DB
 * Report state is shown in the side nav's "review" section once it
leaves "draft" mode
 * Policy, service and route added to update status of a report
@jasalisbury
Copy link
Author

API docs aren't working for me for some reason, will look into it.

@dcmcand
Copy link

dcmcand commented Feb 2, 2021

Currently the manager notes are not connected to a particular user. I know that there will only be one approving manager per activity report, but I could see a situation where the approving manager gets changed. Is this a concern? Something to look at post mvp?

@jasalisbury
Copy link
Author

Currently the manager notes are not connected to a particular user. I know that there will only be one approving manager per activity report, but I could see a situation where the approving manager gets changed. Is this a concern? Something to look at post mvp?

That is a good question. My first thought is to not worry about it until after the MVP, thoughts @rahearn?

@rahearn
Copy link

rahearn commented Feb 2, 2021

My first thought is to not worry about it until after the MVP

Yeah, it's not ideal but I think we can punt this until we implement multiple approvals.

Copy link

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Conflicts:
	docs/logical_data_model.md
	frontend/src/components/Navigator/index.js
@jasalisbury jasalisbury merged commit d31f14f into main Feb 4, 2021
@jasalisbury jasalisbury deleted the js-137-manager-approves-report branch February 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants