-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managers can add notes and set status of reports #139
Conversation
* Review page is now different if the user looking at the page is the approving manager * Manager's review page includes the user's additional note and allows the manager to leave a manager note * Manager note added to DB * Report state is shown in the side nav's "review" section once it leaves "draft" mode * Policy, service and route added to update status of a report
API docs aren't working for me for some reason, will look into it. |
Currently the manager notes are not connected to a particular user. I know that there will only be one approving manager per activity report, but I could see a situation where the approving manager gets changed. Is this a concern? Something to look at post mvp? |
That is a good question. My first thought is to not worry about it until after the MVP, thoughts @rahearn? |
Yeah, it's not ideal but I think we can punt this until we implement multiple approvals. |
…/Head-Start-TTADP into js-137-manager-approves-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Conflicts: docs/logical_data_model.md frontend/src/components/Navigator/index.js
Description of change
How to test
CURRENT_USER_ID
is set to "1"Review and submit
section updatesIssue(s)
Checklist