Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Add Incomplete Loadout Tooltips #10572

Merged
merged 5 commits into from
Jan 4, 2025

Conversation

SpicyBagpipes
Copy link
Contributor

When merged this pull request will:

  • Adds CBA option for incomplete loadout tooltips
  • Will give a tooltip for each unique item that is missing from the arsenal (Not working on null items is intended)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Contributor Author

Don't know how to mark a PR as draft, but I have no idea why this doesn't work. The command runs and I cannot see any syntax errors.

@SpicyBagpipes SpicyBagpipes marked this pull request as draft December 19, 2024 01:20
@LinkIsGrim
Copy link
Contributor

IMO doesn't need to be a setting?

@SpicyBagpipes
Copy link
Contributor Author

IMO doesn't need to be a setting?

Lots of loadouts would make moving mouse over loadouts screen obnoxious imo

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 20, 2024
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Dec 20, 2024
@LinkIsGrim LinkIsGrim added the kind/setting Release Notes: **SETTINGS:** label Dec 20, 2024
@johnb432
Copy link
Contributor

johnb432 commented Jan 4, 2025

@SpicyBagpipes Is there anything else you want to add?

@SpicyBagpipes
Copy link
Contributor Author

@SpicyBagpipes Is there anything else you want to add?

Nope

@johnb432 johnb432 marked this pull request as ready for review January 4, 2025 18:44
@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.18.2 Jan 4, 2025
@LinkIsGrim LinkIsGrim merged commit 183a8d4 into acemod:master Jan 4, 2025
3 checks passed
@SpicyBagpipes SpicyBagpipes deleted the loadout-tooltips branch January 4, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants