-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Treatment - Change adv. diagnose default setting to 2 #10548
base: master
Are you sure you want to change the base?
Medical Treatment - Change adv. diagnose default setting to 2 #10548
Conversation
https://github.com/acemod/ACE3/blob/1e404cf85b2af8ad575c5f053fe0205e9ffa2470/addons/repair/functions/fnc_isEngineer.sqf This function is public api, this here should be too
This reverts commit ed96e36.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the reasoning, see what others think.
This setting was really just added for gameplay reasons I think we should just keep the default realistic setting and anyone who wants to change it can and probably already has |
i recently played with a community which never bothered going into these details. when i told them, hey, you can turn that on and get the additional clue they were happy, since they were not aware of that.
If they are aware of it yea, but if they dont even know the setting exist, they need someone to do a deep dive into it - if they dont, they wont notice it. I still think for the majority of players it will be beneficial to have this additional way of diagnosing someone's dead. If a community chooses to go the "full realism route" you most likely have them be aware of the settings and go through these settings already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with making defaults more gameplay-oriented. Competent super-hardcore milsim communities will be checking the changelog anyway.
When merged this pull request will:
Why:
I cant think of any reason why it should stay at 1.
The only thing that 2 does over the current default of 1 is to provide additional Information while checking Response, giving the player the chance to Identify a fully dead patient.
Since the "old way" of stepping on the patient and checking for collision is still doable but kinda immersion breaking, i suggest to change it to 2 to improve the experience for people who never bothered check the settings.