Interaction - Add Interaction to take another players launcher

[Cplhardcore]

When merged this pull request will:

• Allow players to take launchers off others backs, without needing to go through the inventory

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[DartRuffian]

I'm not sure if that _x in getArray (...) check is necessary, are there times where a launcher has a non-compatible magazine loaded?

addMagazine should probably use a CBA / ACE function that also checks if the magazine can be added, and drops on the ground if it can't be.

Suggested change

	private _CfgWeapons = configFile >> "CfgWeapons" >> _launcher;
	private _attachments = _target weaponAccessories _launcher;
	private _launcherAmmo = (currentMagazine _unit) select {
	_x in getArray (configFile >> "CfgWeapons" >> _launcherClassname >> "magazines")
	};
	_target removeWeapon _launcher;
	{
	_unit removeMagazine _x;
	} forEach _launcherAmmo;
	_player addWeapon _launcher;
	{_player addSecondaryWeaponItem _x;} forEach _attachments;
	{_unit addMagazine _x;} forEach _launcherAmmo;
	if (_animate) then {[_player, "PutDown"] call EFUNC(common,doGesture)};
	private _playerName = [_player] call EFUNC(common,getName);
	private _displayName = getText (_cfgWeapons >> "displayName");
	private _weaponConfig = configFile >> "CfgWeapons" >> _launcher;
	private _attachments = _target weaponAccessories _launcher;
	private _magazines = magazines _unit select {
	_x in getArray (_weaponConfig >> "magazines")
	};
	_target removeWeapon _launcher;
	{ _unit removeMagazine _x } forEach _magazines;
	_player addWeapon _launcher;
	{ _player addSecondaryWeaponItem _x } forEach _attachments;
	{ _unit addMagazine _x } forEach _magazines;
	if (_animate) then {[_player, "PutDown"] call EFUNC(common,doGesture)};
	private _playerName = [_player] call EFUNC(common,getName);
	private _displayName = getText (_weaponConfig >> "displayName");

[rautamiekka]

I'm not sure if that _x in getArray (...) check is necessary, are there times where a launcher has a non-compatible magazine loaded?

addMagazine should probably use a CBA / ACE function that also checks if the magazine can be added, and drops on the ground if it can't be.

Note: the config path in the line 31 of the suggested change should be saved into a var to avoid a potentially repeated lookup.

[DartRuffian]

I left that part as is for the same reason john commented later, that select statement doesn't account for compatible magazines added through magazine wells.

If I had to guess, CBA / ACE has some function that also takes this into account

[PabstMirror]

Don't use (getArray ... "magazines") because it doesn't support mag wells (which I think are used for some rpgs?)
just use compatibleMagazines

also need to think about 2nd muzzle (smaw)

[Cplhardcore]

Current issue with handling multiple muzzles, it breaks disposables

[johnb432]

1. _unit is undefined (another undefined _unit exists further below).
2. currentMagazine is a string. I'm guessing you wanted magazines?
3. Ammo counts are disregarded, when they need to be taken into account (some Halo launchers use magazines with multiple rounds).
4. This code disregards any compatible ammo added via magwells.

I'm honestly not sure what you're trying to achieve here. Are you trying to just pass the loaded magazine or are you trying to pass all compatible magazines for the launcher?

[Cplhardcore]

Trying to get the currently loaded magazine in the launcher, but from what I can tell there isn't a command to do that, so I'm looking at using magazines

[DartRuffian]

There is, currentMagazineDetails

[johnb432]

Don't use currentMagazineDetail, you have to do parsing to get the ammo count.
weaponState gives you both magazine classname and ammo count.

[DartRuffian]

I said the same thing on discord and Drofresh said that, completely forgot about weaponState again

[Cplhardcore]

yeah, im using weaponState rn

[rautamiekka]

I'm not sure if that _x in getArray (...) check is necessary, are there times where a launcher has a non-compatible magazine loaded?

addMagazine should probably use a CBA / ACE function that also checks if the magazine can be added, and drops on the ground if it can't be.

Note: the config path in the line 31 of the suggested change should be saved into a var to avoid a potentially repeated lookup.

[Cplhardcore]

Right now this PR is on hold, as support for multiple muzzles breaks disposables

[Cplhardcore]

thanks to johnb, this PR should be good to go