Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aegis Compat - Add realistic names for basegame variants #10370

Merged

Conversation

rekterakathom
Copy link
Contributor

@rekterakathom rekterakathom commented Oct 7, 2024

When merged this pull request will:

  • Add realistic names to all Aegis primary weapons

Aegis SPAR-16 could reference the realisticnames stringtable instead of being "duplicated", but I've done it this way in case either one should be changed in the future. Issue opening pending to discuss the naming of the SPAR-16s in the realisticnames addon.

Edit: Link to naming discussion

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432
Copy link
Contributor

johnb432 commented Oct 7, 2024

Aegis SPAR-16 could reference the realisticnames stringtable instead of being "duplicated", but I've done it this way in case either one should be changed in the future. Issue opening pending to discuss the naming of the SPAR-16s in the realisticnames addon.

Imo not a good reason: If something changes in the future, you have to redo all translations either way.

General formatting, use realisticnames stringtable for SPAR-16
@rekterakathom
Copy link
Contributor Author

Formatting fixed, changed the SPAR-16 to use the realisticnames stringtable to avoid duplication

@johnb432
Copy link
Contributor

Add realistic names to all Aegis primary weapons

Currently, this only renames weapons that are part of the basegame, it doesn't affect any of the weapons that the mods adds (e.g. AK-103, AK-12, AK-74 etc.). Change the description to reflect that please.

If you want to, you can rename the rest of the weapons and add it to this PR, but imo this is enough as it is.

@johnb432 johnb432 added the kind/feature Release Notes: **ADDED:** label Oct 12, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 12, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, LGTM

@LinkIsGrim LinkIsGrim changed the title Aegis Compat - Add realistic primary weapon names Aegis Compat - Add realistic names for basegame variants Oct 15, 2024
@LinkIsGrim LinkIsGrim merged commit ee1a0c2 into acemod:master Oct 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants