-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aegis Compat - Add realistic names for basegame variants #10370
Aegis Compat - Add realistic names for basegame variants #10370
Conversation
Imo not a good reason: If something changes in the future, you have to redo all translations either way. |
General formatting, use realisticnames stringtable for SPAR-16
Formatting fixed, changed the SPAR-16 to use the |
Currently, this only renames weapons that are part of the basegame, it doesn't affect any of the weapons that the mods adds (e.g. AK-103, AK-12, AK-74 etc.). Change the description to reflect that please. If you want to, you can rename the rest of the weapons and add it to this PR, but imo this is enough as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comment, LGTM
When merged this pull request will:
Aegis SPAR-16 could reference the
realisticnames
stringtable instead of being "duplicated", but I've done it this way in case either one should be changed in the future. Issue opening pending to discuss the naming of the SPAR-16s in therealisticnames
addon.Edit: Link to naming discussion
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.