Common - Check extensions hash #10144
Open
+98
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add to existing |
|
we're dropping that in rust pr #9015, this should be compatible before/after that |
LinkIsGrim
approved these changes
Aug 11, 2024
johnb432
reviewed
Oct 12, 2024
johnb432
approved these changes
Oct 12, 2024
|
johnb432
reviewed
Jan 3, 2025
Co-authored-by: johnb432 <[email protected]>
johnb432
approved these changes
Jan 4, 2025
|
|
||
| // Check for correct hash | ||
| if (GVAR(checkExtensions)) then { | ||
| { |
There was a problem hiding this comment.
Calling allExtensions is expensive, might as well cache the result.
Suggested change
| { | |
| private _allExtensions = allExtensions; | |
| { |
| if ((_x getOrDefault ["name", ""]) == _extName) exitWith { | ||
| _extensionHash = _x getOrDefault ["hash", ""]; | ||
| }; | ||
| } forEach allExtensions; |
There was a problem hiding this comment.
Suggested change
| } forEach allExtensions; | |
| } forEach _allExtensions; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies extensions hash