Skip to content

Commit

Permalink
PR #1775: Support symbolize only on WINAPI_PARTITION_DESKTOP
Browse files Browse the repository at this point in the history
Imported from GitHub PR #1775

Win32 `dbhelp.h` defines `SYMBOL_INFO` structure under `WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)` guard. Any other partition will have these symbols undefined.

Follow same logic in `symbolize.cc` to prevent compilation failure on non-Desktop platforms.
Merge 0081212 into 8783136

Merging this change closes #1775

COPYBARA_INTEGRATE_REVIEW=#1775 from redbaron:patch-1 0081212
PiperOrigin-RevId: 689022871
Change-Id: If68795b432b3d09b999aa52cb629c5ad2b6eb75c
  • Loading branch information
redbaron authored and copybara-github committed Oct 23, 2024
1 parent 45c456b commit 4fed124
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions absl/debugging/symbolize.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// SKIP_ABSL_INLINE_NAMESPACE_CHECK

#include "absl/debugging/symbolize.h"

#ifdef _WIN32
#include <winapifamily.h>
#if !(WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_APP)) || \
WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)
#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)
// UWP doesn't have access to win32 APIs.
#define ABSL_INTERNAL_HAVE_SYMBOLIZE_WIN32
#endif
Expand Down

0 comments on commit 4fed124

Please sign in to comment.