Skip to content

Commit

Permalink
Require through an internal presubmit that .h|.cc|.inc files contain
Browse files Browse the repository at this point in the history
either the string ABSL_NAMESPACE_BEGIN or SKIP_ABSL_INLINE_NAMESPACE_CHECK

A lot of files are currently missing one or the other. These will be
updated when the files change (triggering the presubmit on the file)
or though a followup mass update.

PiperOrigin-RevId: 688985640
Change-Id: If2d3f3fcd6b41a7452198ba9de13c8633d6051c6
  • Loading branch information
derekmauro authored and copybara-github committed Oct 23, 2024
1 parent 0b78b5b commit 45c456b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions absl/base/attributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
// `__has_attribute()` first. If the check fails, we check if we are on GCC and
// assume the attribute exists on GCC (which is verified on GCC 4.7).

// SKIP_ABSL_INLINE_NAMESPACE_CHECK

#ifndef ABSL_BASE_ATTRIBUTES_H_
#define ABSL_BASE_ATTRIBUTES_H_

Expand Down
2 changes: 2 additions & 0 deletions absl/base/policy_checks.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
// reported with `#error`. This enforcement is best effort, so successfully
// compiling this header does not guarantee a supported configuration.

// SKIP_ABSL_INLINE_NAMESPACE_CHECK

#ifndef ABSL_BASE_POLICY_CHECKS_H_
#define ABSL_BASE_POLICY_CHECKS_H_

Expand Down

0 comments on commit 45c456b

Please sign in to comment.