Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify evaluation process and criteria #1362

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Clarify evaluation process and criteria #1362

merged 5 commits into from
Oct 12, 2021

Conversation

ericwbailey
Copy link
Member

This PR addresses #1319. It reorganizes the Contributing Guidelines page to:

  • Lead with what content we do support, while moving what we no longer support lower down on the page.
  • Consolidate our evaluation and rejection policies.
  • De-emphasize GitHub-related information in anticipation of Our non-GitHub editorial process is opaque #1359.

@ericwbailey ericwbailey added the content Issues dealing with our published content. label Oct 11, 2021
@boring-cyborg boring-cyborg bot added the markup Issues dealing with markup label Oct 11, 2021
mxmason
mxmason requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, friend! Just one thought, and please feel free to tweak my suggestion. If you feel strongly about the original wording you chose, just let me know and I will rescind my request for changes.

src/contributing-guidelines.njk Outdated Show resolved Hide resolved
src/contributing-guidelines.njk Outdated Show resolved Hide resolved
@ericwbailey
Copy link
Member Author

@mxmason I liked your suggestion a lot. Updated!

mxmason
mxmason approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for active voice!

@ericwbailey ericwbailey merged commit 577b032 into main Oct 12, 2021
@ericwbailey ericwbailey deleted the clarify-evaluation-criteria branch October 12, 2021 01:02
@ericwbailey ericwbailey mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmason mxmason mxmason approved these changes

Assignees
No one assigned
Labels
content Issues dealing with our published content. markup Issues dealing with markup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericwbailey @mxmason