Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

´Use g++ and clang++ instead of gcc and clang as C++ compilers #4234

Merged
merged 7 commits into from
Feb 26, 2024
Merged

´Use g++ and clang++ instead of gcc and clang as C++ compilers #4234

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe34aba
´Use g++ and clang++ instead of gcc and clang as C++ compilers
RCoeurjoly Feb 23, 2024
a69a89f
LD is removed, we use CXX instead
RCoeurjoly Feb 25, 2024
033fa10
We use CXX instead of LD for linking yosys-filterlib
RCoeurjoly Feb 25, 2024
dea4aea
LDLIBS -> LIBS. LDFLAGS -> LINKFLAGS
RCoeurjoly Feb 25, 2024
4a2fb18
Changes in libs, passes and tests Makefiles. LDLIBS -> LIBS. LDFLAGS …
RCoeurjoly Feb 25, 2024
cf7b6c6
Changes in misc/yosys-config.in. LDLIBS -> LIBS. LDFLAGS -> LINKFLAGS.
RCoeurjoly Feb 25, 2024
5fa609b
Fix help of yosys-config.in and provide backward compatibility
RCoeurjoly Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions misc/yosys-config.in
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ help() {
echo "Replacement args:"
echo " --cxx @CXX@"
echo " --cxxflags $( echo '@CXXFLAGS@' | fmt -w60 | sed ':a;N;$!ba;s/\n/ \\\n /g' )"
echo " --ldflags @LDFLAGS@"
echo " --ldlibs @LDLIBS@"
echo " --ldflags @LINKFLAGS@"
echo " --ldlibs @LIBS@"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename them here as well, while providing compatibility:

Suggested change
echo " --ldflags @LINKFLAGS@"
echo " --ldlibs @LIBS@"
echo " --linkflags @LINKFLAGS@"
echo " --ldflags (alias of --linkflags)
echo " --linklibs @LIBS@"
echo " --ldlibs (alias of --linklibs)

echo " --bindir @BINDIR@"
echo " --datdir @DATDIR@"
echo ""
Expand Down Expand Up @@ -64,9 +64,9 @@ for opt; do
"$prefix"cxxflags)
tokens=( "${tokens[@]}" @CXXFLAGS@ ) ;;
"$prefix"ldflags)
tokens=( "${tokens[@]}" @LDFLAGS@ ) ;;
tokens=( "${tokens[@]}" @LINKFLAGS@ ) ;;
"$prefix"ldlibs)
tokens=( "${tokens[@]}" @LDLIBS@ ) ;;
tokens=( "${tokens[@]}" @LIBS@ ) ;;
"$prefix"bindir)
tokens=( "${tokens[@]}" '@BINDIR@' ) ;;
"$prefix"datdir)
Expand Down Expand Up @@ -104,4 +104,3 @@ fi

echo "${tokens[@]}"
exit 0