cxxrtl: Fix ctlz, udivmod
#4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @merryhime, I cannot formally request review but I am requesting review |
|
Huh, tests still stuck? |
|
|
|
Now, hopefully? |
povik
force-pushed
the
cxxrtl-udivmod-fix
branch
from
9c0579a
to
18d1907
Compare
povik
commented
Dec 12, 2023
| divisor = divisor.shl(value<Bits>{divisor_shift}); | ||
| int64_t divisor_shift = divisor.ctlz() - dividend.ctlz(); | ||
| assert(divisor_shift >= 0); | ||
| divisor = divisor.shl(value<Bits>{(chunk::type) divisor_shift}); |
There was a problem hiding this comment.
Force pushed to make this cast to chunk::type instead of unsigned int
|
OK, there's the usual fluke CI failure on macOS but other than that the hang is no more. |
|
@povik Thanks for handling this! |
|
@whitequark Will you be able to review this today? If not we might need to revert #4061 to unblock CI. |
merryhime
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix
ctlzand give it the usual semantics, then adjusted thedivisor_shiftcalculation inudivmodappropriately.