Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASI CI build #4051

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Add WASI CI build #4051

merged 2 commits into from
Dec 6, 2023

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Dec 5, 2023

Added script from #4045, was not able to reproduce a bug but it more looks like order of execution issue in passes/pmgen directory. Let see if this CI is happy.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povik
Copy link
Member

povik commented Dec 5, 2023

I am not that familiar with GitHub Actions but I wonder if splitting the SDK fetch from the other commands and putting it above the source checkout would cause GitHub to sometimes cache the environment with the unpacked SDK tree

@mmicko
Copy link
Member Author

mmicko commented Dec 5, 2023

No caching enabled here so no issues. Spliting into multiple steps does not help since there is no reuse. Leaving this to be decided on Mondays meeting.

@povik
Copy link
Member

povik commented Dec 5, 2023

Well, I meant caching by the GitHub infrastructure itself, since it sees there are no variable inputs to the workflow up to the point of the source checkout. Though it's probably not that clever to deduce the link to the SDK hasn't changed content

@whitequark
Copy link
Member

Well, I meant caching by the GitHub infrastructure itself, since it sees there are no variable inputs to the workflow up to the point of the source checkout. Though it's probably not that clever to deduce the link to the SDK hasn't changed content

GitHub does no such thing. We could make it cache explicitly but there's no point since the SDK is downloaded from GitHub's infrastructure in the first place. There would be no meaningful difference in speed, it would just waste some space.

@mmicko mmicko merged commit 45dd9ec into master Dec 6, 2023
34 checks passed
@mmicko mmicko deleted the wasi_ci branch December 6, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants