Skip to content

[test] Use struct.new_desc in JS API test #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
Feb 5, 2026
Merged

[test] Use struct.new_desc in JS API test #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/js-api/custom-descriptors/prototype.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ setup(() => {
.addBody([
kExprLocalGet, 0,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNew, structIndex
kGCPrefix, kExprStructNewDesc, structIndex
])
.exportFunc();

Expand Down Expand Up @@ -68,7 +68,7 @@ test(() => {
const objIndex = builder.addGlobal(wasmRefType(structIndex), false, [
kExprGlobalGet, 0,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNew, structIndex,
kGCPrefix, kExprStructNewDesc, structIndex,
]);
builder.addExportOfKind("obj", kExternalGlobal, objIndex.index);

Expand Down Expand Up @@ -102,7 +102,7 @@ test(() => {
.addBody([
kExprLocalGet, 0,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNew, structIndex
kGCPrefix, kExprStructNewDesc, structIndex
])
.exportFunc();

Expand Down Expand Up @@ -135,7 +135,7 @@ test(() => {
kExprI32Const, 0,
kExprLocalGet, 0,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNew, structIndex
kGCPrefix, kExprStructNewDesc, structIndex
])
.exportFunc();

Expand Down Expand Up @@ -166,7 +166,7 @@ test(() => {
.addBody([
kExprLocalGet, 0,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNew, structIndex
kGCPrefix, kExprStructNewDesc, structIndex
])
.exportFunc();

Expand Down Expand Up @@ -203,7 +203,7 @@ test(() => {
.addBody([
kExprLocalGet, 0,
kGCPrefix, kExprStructNew, metaIndex,
kGCPrefix, kExprStructNew, descIndex,
kGCPrefix, kExprStructNewDesc, descIndex,
Copy link

@rmahdav rmahdav Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be descIndex or structIndex (like the similar lines)? or maybe the rest of the lines should also have descIndex instead of structIndex?

Copy link
Member Author

@tlively tlively Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intentional that the names are different in this test. Most of the tests have setups like this:

struct -> desc

Where the prototype is being configured on desc. But this test uses this setup instead:

struct -> desc -> meta

And the prototype is configured on meta. So the names for the base described struct and its descriptor are the same as in the other tests, but this test additionally adds meta as the descriptor of the descriptor and uses in where the previous tests would have used desc.

Copy link

@rmahdav rmahdav Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. thanks for the expalanation.

])
.exportFunc();

Expand Down