Merged
Conversation
Update custom-descriptors/prototype.any.js to correctly use struct.new_desc when allocating types with descriptors.
rmahdav
reviewed
Feb 5, 2026
| kExprLocalGet, 0, | ||
| kGCPrefix, kExprStructNew, metaIndex, | ||
| kGCPrefix, kExprStructNew, descIndex, | ||
| kGCPrefix, kExprStructNewDesc, descIndex, |
There was a problem hiding this comment.
Should this be descIndex or structIndex (like the similar lines)? or maybe the rest of the lines should also have descIndex instead of structIndex?
Member
Author
There was a problem hiding this comment.
It's intentional that the names are different in this test. Most of the tests have setups like this:
struct -> desc
Where the prototype is being configured on desc. But this test uses this setup instead:
struct -> desc -> meta
And the prototype is configured on meta. So the names for the base described struct and its descriptor are the same as in the other tests, but this test additionally adds meta as the descriptor of the descriptor and uses in where the previous tests would have used desc.
rmahdav
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update custom-descriptors/prototype.any.js to correctly use
struct.new_desc when allocating types with descriptors.