Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make multiple roles per group/user GA by removing the flag #5109

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Oct 20, 2023

To prepare for 5.6 GA,
I've done a find through both Frontend and Backend here to remove the usages of the flag. Seems like the flag was only in use in the frontend. @nunogois can you confirm?

@chriswk chriswk requested a review from nunogois October 20, 2023 08:35
@chriswk chriswk self-assigned this Oct 20, 2023
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 0:25am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 0:25am

@chriswk chriswk force-pushed the task/removeMultipleRolesFlagForGA branch from 7b825fd to 37cbfb4 Compare October 20, 2023 08:35
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, that's the only place where it was evaluated.

We can also clean it up from:

  • frontend/cypress/integration/projects/access.spec.ts
  • frontend/src/interfaces/uiConfig.ts

GJ 👍

@chriswk
Copy link
Member Author

chriswk commented Oct 20, 2023

will do

@chriswk chriswk force-pushed the task/removeMultipleRolesFlagForGA branch from 37cbfb4 to 8d23890 Compare October 23, 2023 12:24
@chriswk chriswk enabled auto-merge (squash) October 23, 2023 12:26
@chriswk chriswk merged commit 314a08b into main Oct 23, 2023
13 checks passed
@chriswk chriswk deleted the task/removeMultipleRolesFlagForGA branch October 23, 2023 12:32
nunogois added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants