Skip to content

Commit

Permalink
refactor: slight clean up after GAing multiple roles (#5133)
Browse files Browse the repository at this point in the history
Follow up cleanup to #5109
Based on
#5109 (review)
  • Loading branch information
nunogois authored Oct 24, 2023
1 parent 599da89 commit 90296be
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
13 changes: 0 additions & 13 deletions frontend/cypress/integration/projects/access.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,6 @@ describe('project-access', () => {
beforeEach(() => {
cy.login_UI();

cy.intercept('GET', `${baseUrl}/api/admin/ui-config`, (req) => {
req.headers['cache-control'] =
'no-cache, no-store, must-revalidate';
req.on('response', (res) => {
if (res.body) {
res.body.flags = {
...res.body.flags,
multipleRoles: true,
};
}
});
});

cy.visit(`/projects/${groupAndProjectName}/settings/access`);
if (document.querySelector("[data-testid='CLOSE_SPLASH']")) {
cy.get("[data-testid='CLOSE_SPLASH']").click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import {
import { caseInsensitiveSearch } from 'utils/search';
import { IServiceAccount } from 'interfaces/service-account';
import { MultipleRoleSelect } from 'component/common/MultipleRoleSelect/MultipleRoleSelect';
import { RoleSelect } from 'component/common/RoleSelect/RoleSelect';

const StyledForm = styled('form')(() => ({
display: 'flex',
Expand Down
1 change: 0 additions & 1 deletion frontend/src/interfaces/uiConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export type UiFlags = {
customRootRolesKillSwitch?: boolean;
strategyVariant?: boolean;
lastSeenByEnvironment?: boolean;
multipleRoles?: boolean;
featureNamingPattern?: boolean;
doraMetrics?: boolean;
variantTypeNumber?: boolean;
Expand Down

0 comments on commit 90296be

Please sign in to comment.