Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve access service #4689

Merged
merged 17 commits into from
Sep 19, 2023
Merged

chore: improve access service #4689

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4e0ba5a
test: why does it fail?
gastonfournier Sep 13, 2023
45c285e
Fix test
gastonfournier Sep 13, 2023
f3aa636
Add support for named permissions
gastonfournier Sep 15, 2023
7ae3f98
Merge remote-tracking branch 'origin/main' into improve-access-service
gastonfournier Sep 15, 2023
16c6aac
Remove some test logs
gastonfournier Sep 15, 2023
dd54d05
Fix incompatibility with fake store
gastonfournier Sep 15, 2023
c7b12a7
Fix compilation issue
gastonfournier Sep 15, 2023
8583c22
Merge remote-tracking branch 'origin/main' into improve-access-service
gastonfournier Sep 15, 2023
45dacbc
Adapt to new interface
gastonfournier Sep 15, 2023
7a61c4a
Add tests to resolve permissions
gastonfournier Sep 15, 2023
67fcced
Remove unnecessary comment
gastonfournier Sep 15, 2023
a90c83d
Merge remote-tracking branch 'origin/main' into improve-access-service
gastonfournier Sep 18, 2023
ca01f42
Update src/lib/db/access-store.test.ts
gastonfournier Sep 19, 2023
7b6596e
Update src/lib/db/access-store.test.ts
gastonfournier Sep 19, 2023
6d8831b
Merge remote-tracking branch 'origin/main' into improve-access-service
gastonfournier Sep 19, 2023
84a17f9
lint
gastonfournier Sep 19, 2023
d5c3402
Add timer to transform permission names to ids
gastonfournier Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/test/e2e/services/access-service.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,13 +363,21 @@
permissions.CREATE_FEATURE,
'*',
);
expect(
await accessService.hasPermission(user, CREATE_FEATURE, 'default'),
).toBe(true);

await accessService.removePermissionFromRole(
editRole.id,
permissions.CREATE_FEATURE,
'*',
);

expect(
await accessService.hasPermission(user, CREATE_FEATURE, 'default'),
).toBe(false);

Check failure on line 378 in src/test/e2e/services/access-service.e2e.test.ts

View workflow job for this annotation

GitHub Actions / Unit Tests

src/test/e2e/services/access-service.e2e.test.ts ► -should remove CREATE_FEATURE on default environment ► -should remove CREATE_FEATURE on default environment 

Failed test found in:
  jest-junit.xml
Error:
  Error: expect(received).toBe(expected) // Object.is equality
Raw output 
Error: expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true
    at Object.toBe (/home/runner/work/unleash/unleash/src/test/e2e/services/access-service.e2e.test.ts:378:7)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

// if project does not exist we also return false
expect(
await accessService.hasPermission(user, CREATE_FEATURE, 'some-project'),
).toBe(false);
Expand Down
Loading